Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated boot screen #15125

Closed
wants to merge 1 commit into from
Closed

Fix repeated boot screen #15125

wants to merge 1 commit into from

Conversation

Ludy87
Copy link
Contributor

@Ludy87 Ludy87 commented Sep 1, 2019

The logo will appear twice, as you can see by enable BOOT_MARLIN_LOGO_ANIMATED

The logo will appear twice, as you can see by enable `BOOT_MARLIN_LOGO_ANIMATED`
@thinkyhead thinkyhead changed the title fixes the double calling of the Marlin boot logo Fix repeated boot screen Sep 1, 2019
@thinkyhead
Copy link
Member

If the logo is too large to display more than one line of text, the first draw will display the first line of text and the second draw (q == 0) will draw the second line of text.

@thinkyhead thinkyhead closed this Sep 1, 2019
@Ludy87
Copy link
Contributor Author

Ludy87 commented Sep 1, 2019

If I activate the BOOT_MARLIN_LOGO_SMALL it will still run twice, which is normal if the value is 2

@Ludy87
Copy link
Contributor Author

Ludy87 commented Sep 1, 2019

@thinkyhead
Copy link
Member

If I activate the BOOT_MARLIN_LOGO_SMALL it will still run twice, which is normal if the value is 2

The test to see whether is should run twice cannot be based simply on BOOT_MARLIN_LOGO_SMALL but should be based on how many "splash lines" are defined and whether there is enough space for two lines below the logo.

@Ludy87
Copy link
Contributor Author

Ludy87 commented Sep 3, 2019

Now I understand what you mean, then I have to look at the size ratio.

@Ludy87
Copy link
Contributor Author

Ludy87 commented Sep 3, 2019

Would that be an alternative?
Ludy87@441b253

@thinkyhead
Copy link
Member

I've merged a patch that should cover all cases.

thinkyhead added a commit that referenced this pull request Sep 4, 2019
Followup to #15125

Co-Authored-By: Ludy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants